Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move temporary error logs to lower level than WARN #897

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Move temporary error logs to lower level than WARN #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0734da
Move temporary error logs to debug instead of warn
sergerad Jan 12, 2025
9a01fd0
Use trace
sergerad Jan 12, 2025
9c477d5
Reword log line
sergerad Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/derive/src/pipeline/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ where
}
StepResult::AdvancedOrigin
}
PipelineErrorKind::Temporary(_) => {
trace!(target: "pipeline", "Attributes queue step failed due to temporary error: {:?}", err);
StepResult::StepFailed(err)
}
_ => {
warn!(target: "pipeline", "Attributes queue step failed: {:?}", err);
StepResult::StepFailed(err)
Expand Down
13 changes: 9 additions & 4 deletions crates/driver/src/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,16 @@ where
info!(target: "client_derivation_driver", "Advanced origin")
}
StepResult::OriginAdvanceErr(e) | StepResult::StepFailed(e) => {
warn!(target: "client_derivation_driver", "Failed to step derivation pipeline: {:?}", e);

// Break the loop unless the error signifies that there is not enough data to
// complete the current step. In this case, we retry the step to see if other
// stages can make progress.
match e {
PipelineErrorKind::Temporary(_) => continue,
PipelineErrorKind::Temporary(_) => {
trace!(target: "client_derivation_driver", "Failed to step derivation pipeline temporarily: {:?}", e);
continue
}
PipelineErrorKind::Reset(e) => {
warn!(target: "client_derivation_driver", "Failed to step derivation pipeline due to reset: {:?}", e);
let system_config = self
.system_config_by_number(l2_safe_head.block_info.number)
.await?;
Expand Down Expand Up @@ -85,7 +87,10 @@ where
.await?;
}
}
PipelineErrorKind::Critical(_) => return Err(e),
PipelineErrorKind::Critical(_) => {
warn!(target: "client_derivation_driver", "Failed to step derivation pipeline: {:?}", e);
return Err(e)
}
}
}
}
Expand Down
Loading