Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): Interop binary #903

Merged
merged 4 commits into from
Jan 14, 2025
Merged

feat(client): Interop binary #903

merged 4 commits into from
Jan 14, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 14, 2025

Overview

Adds a new entrypoint to kona-client for the interop binary

@clabby clabby added A-client Area: client binary K-feature Kind: feature labels Jan 14, 2025
@clabby clabby requested review from refcell and emhane as code owners January 14, 2025 20:46
@clabby clabby self-assigned this Jan 14, 2025
@clabby
Copy link
Collaborator Author

clabby commented Jan 14, 2025 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

This was referenced Jan 14, 2025
Merged
Open
@clabby clabby force-pushed the cl/client-interop-entrypoint branch from d41533e to f2d7447 Compare January 14, 2025 20:48
refcell
refcell approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different binary entrypoints look good.

Base automatically changed from cl/proof-interop to main January 14, 2025 21:53
@clabby clabby added this pull request to the merge queue Jan 14, 2025
@clabby clabby removed this pull request from the merge queue due to a manual request Jan 14, 2025
@clabby clabby force-pushed the cl/client-interop-entrypoint branch from dcc7b49 to f8741c7 Compare January 14, 2025 22:03
@clabby clabby enabled auto-merge January 14, 2025 22:03
@clabby clabby added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit bf91cfe Jan 14, 2025
14 checks passed
@clabby clabby deleted the cl/client-interop-entrypoint branch January 14, 2025 22:18
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-client Area: client binary K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell