Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Interop consolidation sub-problem #913

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 19, 2025

Overview

Implements the happy-path variant of the consolidation sub-problem for the interop FPP.

This will be followed up with a larger overhaul that allows for re-executing the optimistic blocks with deposits only, in the case where dependencies were found to be invalid.

@clabby clabby added A-client Area: client binary K-feature Kind: feature labels Jan 19, 2025
@clabby clabby self-assigned this Jan 19, 2025
@clabby
Copy link
Collaborator Author

clabby commented Jan 19, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (8e25874) to head (dfed471).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review January 20, 2025 15:35
@clabby clabby requested review from refcell and emhane as code owners January 20, 2025 15:35
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few todos - also beware i saw a mix of INTEROP: and TODO: comment prefixes used over your interop prs. Those will need to be fixed.

@clabby clabby added this pull request to the merge queue Jan 21, 2025
@clabby
Copy link
Collaborator Author

clabby commented Jan 21, 2025

Thanks @refcell - those todos are left there intentionally. I'll comb through them this morning and translate to tickets if I'm not able to get to them today.

Merged via the queue into main with commit c56c3fc Jan 21, 2025
16 checks passed
@clabby clabby deleted the cl/consolidation branch January 21, 2025 14:57
@github-actions github-actions bot mentioned this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants