Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): Migrate to mips64r2 target for cannon #943

Merged
merged 3 commits into from
Jan 24, 2025
Merged

feat(build): Migrate to mips64r2 target for cannon #943

merged 3 commits into from
Jan 24, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 24, 2025

Overview

Migrates the cannon build path to the mips64r2 target.

@clabby clabby self-assigned this Jan 24, 2025
@clabby clabby requested review from refcell and emhane as code owners January 24, 2025 06:28
@clabby clabby added A-build Area: Build Pipelines K-feature Kind: feature labels Jan 24, 2025
@clabby clabby linked an issue Jan 24, 2025 that may be closed by this pull request
spike: mips64r2 target support #942
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.8%. Comparing base (a59f643) to head (1d82122).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby mentioned this pull request Jan 24, 2025
Closed
refcell
refcell approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@clabby clabby added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 4b00849 Jan 24, 2025
16 checks passed
@clabby clabby deleted the cl/cannon64 branch January 24, 2025 16:29
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-build Area: Build Pipelines K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spike: mips64r2 target support
2 participants
@clabby @refcell