Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and updates #77

Merged
merged 3 commits into from
Sep 14, 2019
Merged

Small fixes and updates #77

merged 3 commits into from
Sep 14, 2019

Conversation

hmdne
Copy link
Member

@hmdne hmdne commented Sep 13, 2019

  1. At least Opal 1.0.0 generated incorrect Javascript since the fix for IE11 has been committed
  2. Two x-strings were terminated by semicolons
  3. As of Opal 1.0.0, including Native has been deprecated, this commit replaces all occurrences of that with including Native::Wrapper. You may want to postpone this patch if you want to keep compatibility with older versions of Opal

@hmdne
Revert "[IE11] Fixed support check for Event.constructor"
fb18a77 
This reverts commit 6791db2.

This commit is faulty as of Opal 1.0.0. It produces invalid Javascript code.
@hmdne
Small fix removing semicolons. Fixes those error messages during comp…
83046f3 
…ilation.

warning: Removed semicolon ending x-string expression, interpreted as unintentional -- browser/dom/element/input.rb:24
warning: Removed semicolon ending x-string expression, interpreted as unintentional -- browser/dom/element/input.rb:28
@hmdne
Replace "include Native" with "include Native::Wrapper".
e8c117a 
Opal deprecates the first and suggest replacing it with the second, as per console message:

"Including ::Native is deprecated. Please include Native::Wrapper instead."
@elia
Copy link
Member

elia commented Sep 14, 2019

Great stuff! Thanks for picking up the slack! 💪

@elia elia merged commit bbfd9f8 into opal:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmdne @elia