misc improvements #1910

elia · 2018-12-10T22:17:08Z

Here's a list of changes:

trying to define singleton methods on string/number will raise a TypeError, just like it would in MRI for numbers and frozen strings
dropped the TMP_name_1 format on temp vars in favor of $name$1, should be easier to follow compiled code when sourcemaps ain't enough.
set the displayName on methods, this way we'll get much more readable stack traces, avoiding that browser heuristic for which they'll pick the TMP var name instead of the method name

iliabylich

👍

Remove the TMP_ noise and use cleaner names for punctuation.

That's the same error Ruby raises for numbers and frozen strings.

For better stack traces, even without source maps.

elia added 2 commits December 10, 2018 22:43

Sort Hash unsupported filters

6105d98

Sort Kernel unsupported filters

bdb0c47

elia added language usability Stuff that improves the life of the developer labels Dec 10, 2018

elia self-assigned this Dec 10, 2018

iliabylich approved these changes Dec 10, 2018

View reviewed changes

elia added 4 commits December 10, 2018 23:59

Improve temp function names

69fc09e

Remove the TMP_ noise and use cleaner names for punctuation.

Raise TypeError when def on strings/numbers

8040110

That's the same error Ruby raises for numbers and frozen strings.

Set the displayName for methods

fb9d7bb

For better stack traces, even without source maps.

Typos

ccf73fd

elia force-pushed the elia/misc-improvements branch from 1dcd305 to ccf73fd Compare December 10, 2018 22:59

elia merged commit e7cff26 into master Dec 11, 2018

elia deleted the elia/misc-improvements branch December 11, 2018 00:16

Provide feedback