Fix exception during Hash#each and Hash#each_key if keys get deleted during loop #2403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following ruby:
and executed with matz ruby results in the following expected output:
However, using opal master the following exceptions are thrown (need to comment out the .each ain above code to get the second exception):
This happens because the original $$keys aray is used for the loop. If that gets modified during the loop, the indexes fail to match during the loop, resulting in
null
keys and failing.The patch copies the $$keys using .slice() (the supposedly fastest way to copy arrays) before entering the loop: