Add LVMs LLaVA component #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spycsh <sihan.chen@intel.com>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lvliang-intel
approved these changes
Jun 14, 2024
hshen14
reviewed
Jun 16, 2024
hshen14
reviewed
Jun 16, 2024
Hi @hshen14 The original design here is to not only use LLaVA as the base model which convert image+prompt => text, but also adaptable to use image-captioning models such as vit, blip, which simply convert image=>text. So here I think img2txt is a more general term. What do you think? |
Spycsh
changed the title
Spycsh
changed the title
chensuyue
approved these changes
Jun 19, 2024
XinyuYe-Intel
approved these changes
Jun 19, 2024
sharanshirodkar7
pushed a commit
to sharanshirodkar7/GenAIComps
that referenced
this pull request
Jul 9, 2024
* add img2txt microservice Signed-off-by: Spycsh <sihan.chen@intel.com> * fix * rem * fix * fix * debug * add debug * add standalone llava server to avoid tokenization in diff process issue * add another test * endpoint * debug * rem * fix * disable hpu graph * dockernize * add test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rem nohup * fix * refactor img2txt to lvms * Update test_reranks_langchain.sh * fix test name * rename * lower wait time --------- Signed-off-by: Spycsh <sihan.chen@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Signed-off-by: sharanshirodkar7 <ssharanshirodkar7@gmail.com>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Jul 10, 2024
* add img2txt microservice Signed-off-by: Spycsh <sihan.chen@intel.com> * fix * rem * fix * fix * debug * add debug * add standalone llava server to avoid tokenization in diff process issue * add another test * endpoint * debug * rem * fix * disable hpu graph * dockernize * add test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rem nohup * fix * refactor img2txt to lvms * Update test_reranks_langchain.sh * fix test name * rename * lower wait time --------- Signed-off-by: Spycsh <sihan.chen@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
dwhitena
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Jul 24, 2024
* add img2txt microservice Signed-off-by: Spycsh <sihan.chen@intel.com> * fix * rem * fix * fix * debug * add debug * add standalone llava server to avoid tokenization in diff process issue * add another test * endpoint * debug * rem * fix * disable hpu graph * dockernize * add test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rem nohup * fix * refactor img2txt to lvms * Update test_reranks_langchain.sh * fix test name * rename * lower wait time --------- Signed-off-by: Spycsh <sihan.chen@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <suyue.chen@intel.com> Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add LVMs LLaVA component
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
tests/test_lvm.sh