Reranking using an optimized bi-encoder #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gadmarkovits <gad.markovits@intel.com>
Signed-off-by: gadmarkovits <gad.markovits@intel.com>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
Please add an e2e test for the new rerank, like this one https://github.com/opea-project/GenAIComps/blob/main/tests/test_dataprep_redis_llama_index.sh |
Signed-off-by: gadmarkovits <gad.markovits@intel.com>
Done. |
chensuyue
approved these changes
Jun 24, 2024
Spycsh
approved these changes
Jun 24, 2024
sharanshirodkar7
pushed a commit
to sharanshirodkar7/GenAIComps
that referenced
this pull request
Jul 9, 2024
Signed-off-by: gadmarkovits <gad.markovits@intel.com> Signed-off-by: sharanshirodkar7 <ssharanshirodkar7@gmail.com>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Jul 10, 2024
Signed-off-by: gadmarkovits <gad.markovits@intel.com> Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
dwhitena
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Jul 24, 2024
Signed-off-by: gadmarkovits <gad.markovits@intel.com> Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
lkk12014402
pushed a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new reranker that uses an optimized quantized bi-encoder.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
haystack-ai
Tests
Went through the README and verified that the feature works as intended.