Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'entrypoint.sh' for some Containers #274

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Jul 4, 2024

Description

This PR introduces an entrypoint.sh script to be run at Container startup which is a very common practice by Container developers.

Issues

There are times where more than a single command is required to be run at container entry point and having a script would simplify the Dockerfile design greatly.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [N/A] Bug fix (non-breaking change which fixes an issue)
  • New feature - Pack multiple commands into an script and run that script at Container startup rather than a single command within the body of the container
  • [N/A] Breaking change (fix or feature that would break existing design and interface)

Dependencies

None.

Tests

  • Container builds are successful
  • Running the entrypoint.sh script is relatively fast and does not introduce unacceptable wait time for prompt to be ready
  • Running containers produces output similar to the following which is the expected result:
[2024-07-03 23:35:26,145] [    INFO] - CORS is enabled.
[2024-07-03 23:35:26,146] [    INFO] - Setting up HTTP server
[2024-07-03 23:35:26,146] [    INFO] - Uvicorn server setup on port 9000
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://0.0.0.0:9000 (Press CTRL+C to quit)
[2024-07-03 23:35:26,162] [    INFO] - HTTP server setup successful

ashahba added 6 commits June 30, 2024 16:49
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
ashahba added a commit to ashahba/GenAIComps that referenced this pull request Jul 4, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
@chensuyue chensuyue merged commit 9ecc5c3 into opea-project:main Jul 5, 2024
12 checks passed
@ashahba ashahba deleted the ashahba/langserve branch July 5, 2024 03:27
ashahba added a commit to ashahba/GenAIComps that referenced this pull request Jul 5, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
yogeshmpandey pushed a commit to yogeshmpandey/GenAIComps that referenced this pull request Jul 10, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
dwhitena pushed a commit to predictionguard/GenAIComps that referenced this pull request Jul 24, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants