-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce 'entrypoint.sh' for some Containers #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
ashahba
commented
Jul 4, 2024
ashahba
added a commit
to ashahba/GenAIComps
that referenced
this pull request
Jul 4, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
Spycsh
approved these changes
Jul 5, 2024
chensuyue
approved these changes
Jul 5, 2024
ashahba
added a commit
to ashahba/GenAIComps
that referenced
this pull request
Jul 5, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com> Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
2 tasks
dwhitena
pushed a commit
to predictionguard/GenAIComps
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Abolfazl Shahbazi <abolfazl.shahbazi@intel.com> Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
lkk12014402
pushed a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an
entrypoint.sh
script to be run at Container startup which is a very common practice by Container developers.Issues
There are times where more than a single command is required to be run at container entry point and having a script would simplify the Dockerfile design greatly.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None.
Tests
entrypoint.sh
script is relatively fast and does not introduce unacceptable wait time for prompt to be ready