Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocIndexRetriever] enable the without-rerank flavor #1223

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

gavinlichn
Copy link
Contributor

Description

Enable the without-rerank flavor for DocIndexRetriever
Without-rerank flavor for customers that design to handle all documents by LLM and require high performance of DocRetriever

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@minmin-intel
Copy link
Collaborator

minmin-intel commented Dec 4, 2024

@gavinlichn Please add unit tests for DocIndexRetriever without reranker in test_compose_on_gaudi.sh and test_compose_on_xeon.sh

@gavinlichn
Copy link
Contributor Author

@gavinlichn Please add unit tests for DocIndexRetriever without reranker in test_compose_on_gaudi.sh and test_compose_on_xeon.sh

Submitted new patch for test script test_compose_on_xeon_without_rerank.sh

@minmin-intel
Copy link
Collaborator

@gavinlichn Please add unit tests for DocIndexRetriever without reranker in test_compose_on_gaudi.sh and test_compose_on_xeon.sh

Submitted new patch for test script test_compose_on_xeon_without_rerank.sh

UT needs to be inside test_compose_on_xeon.sh to be intrigued by CI.

ligang and others added 4 commits December 6, 2024 08:10
Without-rerank flavor for customers that design to handle all documents by LLM
and require high performance of DocRetriever

Signed-off-by: Li Gang <gang.g.li@intel.com>
Signed-off-by: Li Gang <gang.g.li@intel.com>
Signed-off-by: Li Gang <gang.g.li@intel.com>
@gavinlichn
Copy link
Contributor Author

@gavinlichn Please add unit tests for DocIndexRetriever without reranker in test_compose_on_gaudi.sh and test_compose_on_xeon.sh

Submitted new patch for test script test_compose_on_xeon_without_rerank.sh

UT needs to be inside test_compose_on_xeon.sh to be intrigued by CI.

renamed the script, UT triggered by CI and passed now

@gavinlichn
Copy link
Contributor Author

@minmin-intel @lvliang-intel Please help to review this PR, it passed all test and pending for review.

@lvliang-intel lvliang-intel merged commit a50e4e6 into opea-project:main Dec 12, 2024
18 checks passed
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Dec 20, 2024
Signed-off-by: Li Gang <gang.g.li@intel.com>
Co-authored-by: ligang <ligang@ligang-nuc9v.bj.intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants