-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DocIndexRetriever] enable the without-rerank flavor #1223
Conversation
@gavinlichn Please add unit tests for DocIndexRetriever without reranker in test_compose_on_gaudi.sh and test_compose_on_xeon.sh |
Submitted new patch for test script test_compose_on_xeon_without_rerank.sh |
UT needs to be inside test_compose_on_xeon.sh to be intrigued by CI. |
979e5c8
to
e9410e7
Compare
Without-rerank flavor for customers that design to handle all documents by LLM and require high performance of DocRetriever Signed-off-by: Li Gang <gang.g.li@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Li Gang <gang.g.li@intel.com>
Signed-off-by: Li Gang <gang.g.li@intel.com>
e9410e7
to
7b1ceae
Compare
renamed the script, UT triggered by CI and passed now |
Signed-off-by: Li Gang <gang.g.li@intel.com>
@minmin-intel @lvliang-intel Please help to review this PR, it passed all test and pending for review. |
Signed-off-by: Li Gang <gang.g.li@intel.com> Co-authored-by: ligang <ligang@ligang-nuc9v.bj.intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Description
Enable the without-rerank flavor for DocIndexRetriever
Without-rerank flavor for customers that design to handle all documents by LLM and require high performance of DocRetriever
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.