Add correct ip to no_proxy list, and add no_proxy env for embedding and reranking containers #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkl2
pushed a commit
to wangkl2/GenAIExamples
that referenced
this pull request
Dec 11, 2024
…-project#269) * Added support for new changes in utils.py Signed-off-by: Yogesh <yogeshpandey@intel.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * trigger GitHub actions Signed-off-by: Yogesh <yogeshpandey@intel.com> --------- Signed-off-by: Yogesh <yogeshpandey@intel.com> Co-authored-by: Yogesh <yogeshpandey@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: lvliang-intel <liang1.lv@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add no_proxy env for embedding-tei-server container
Append host_ip to the no_proxy list
Issues
We need to pass no_proxy setting to embedding and reranking microservices. As in the PR below
(#267)
Also, we need to append host_ip, the public host ipv4 address, to the no_proxy list stored in the no_proxy variable.
Type of change
Dependencies
List the newly introduced 3rd party dependency if exists.
(opea-project/GenAIComps#140)
(#267)
Tests
With this patch,
Embedding Microservice ok
curl http://${host_ip}:6000/v1/embeddings
-X POST
-d '{"text":"hello"}'
-H 'Content-Type: application/json'
Reranking Microservice ok
curl http://${host_ip}:8000/v1/reranking
-X POST
-d '{"initial_query":"What is Deep Learning?", "retrieved_docs": [{"text":"Deep Learning is not..."}, {"text":"Deep learning is..."}]}'
-H 'Content-Type: application/json'