Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all examples yaml files of GMC in GenAIExample #436

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

zhlsunshine
Copy link

Description

Update all examples yaml files of GMC in GenAIExample

Issues

opea-project/GenAIInfra#166
opea-project/GenAIInfra#167

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a.

Tests

Validate the gmc e2e test in GenAIExample

@daisy-ycguo daisy-ycguo added this to the v0.8 milestone Jul 23, 2024
Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove ChatQnA/kubenetes/manifests/README.md one directory up. And delete all other files under manifests directory. The manifests directory should hold the k8s e2e manifests files generated from helm charts.

@zhlsunshine zhlsunshine force-pushed the newgmc branch 4 times, most recently from d9b4da5 to d7b160f Compare July 23, 2024 06:34
@zhlsunshine
Copy link
Author

Please remove ChatQnA/kubenetes/manifests/README.md one directory up. And delete all other files under manifests directory. The manifests directory should hold the k8s e2e manifests files generated from helm charts.

Done

Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
@daisy-ycguo daisy-ycguo merged commit 290a74f into opea-project:main Jul 23, 2024
18 checks passed
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* Update all examples yaml files of GMC in GenAIExample.
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
Signed-off-by: chensuyue <suyue.chen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants