Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI scripts to support more components #473

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

yongfengdu
Copy link
Collaborator

Description

Refactor the CI scripts.

Issues

Closed #471

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions for the CI document.

helm-charts/CI.md Outdated Show resolved Hide resolved
helm-charts/CI.md Outdated Show resolved Hide resolved
helm-charts/CI.md Outdated Show resolved Hide resolved
helm-charts/CI.md Outdated Show resolved Hide resolved
@yongfengdu
Copy link
Collaborator Author

Check Path error is due to CI script error, I've double checked the link is valid.
Guardrails test failure is not related to this change, and need further debug.
Since this PR will trigger all CI tests for helm charts and consume quite a lot resource and will block other changes, let's merge this first and I'll provide a follow up fix for retriever-usvc and prompt-usvc and disable guardrails CI.

@lianhao
Copy link
Collaborator

lianhao commented Oct 16, 2024

Check Path error is due to CI script error, I've double checked the link is valid. Guardrails test failure is not related to this change, and need further debug. Since this PR will trigger all CI tests for helm charts and consume quite a lot resource and will block other changes, let's merge this first and I'll provide a follow up fix for retriever-usvc and prompt-usvc and disable guardrails CI.

fast approve this due to above reasons

@yongfengdu yongfengdu merged commit e09270a into opea-project:main Oct 16, 2024
39 of 44 checks passed
@yongfengdu yongfengdu deleted the ci-fix branch October 16, 2024 05:34
Signed-off-by: Dolpher Du <dolpher.du@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/helm] Enhancement of CI for helm charts
4 participants