Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia documentation #122

Merged
merged 4 commits into from
Sep 16, 2024
Merged

nvidia documentation #122

merged 4 commits into from
Sep 16, 2024

Conversation

srinarayan-srikanthan
Copy link
Contributor

nvidia documentation aligning to the new template.

@srinarayan-srikanthan
nvidia documentation
dfa0142 
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
@srinarayan-srikanthan
documentation update
8b1179d 
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
dbkinder
dbkinder suggested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except I think you intend for this content to in a file called nvidia.md and not nvidia_final_template.md. Please rename it to replace the existing nvidia.md that's there.

@srinarayan-srikanthan
renamed nvidia.md
4d6a3c3 
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
@srinarayan-srikanthan
fixed typo
58f0b86 
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
dbkinder
dbkinder approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks

tomlenth
tomlenth approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbkinder dbkinder merged commit c1e39dc into opea-project:main Sep 16, 2024
1 check passed
@mkbhanda mkbhanda mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkinder dbkinder dbkinder approved these changes

@tomlenth tomlenth tomlenth approved these changes

@chensuyue chensuyue Awaiting requested review from chensuyue chensuyue is a code owner

@ftian1 ftian1 Awaiting requested review from ftian1 ftian1 is a code owner

@mkbhanda mkbhanda Awaiting requested review from mkbhanda mkbhanda is a code owner

@preethivenkatesh preethivenkatesh Awaiting requested review from preethivenkatesh preethivenkatesh is a code owner

@chickenrae chickenrae Awaiting requested review from chickenrae chickenrae is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srinarayan-srikanthan @tomlenth @dbkinder