Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gaudi.md to render on github.io #129

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

ctao456
Copy link
Contributor

@ctao456 ctao456 commented Sep 14, 2024

Tested all command scripts on Gaudi instance, and verified that all services are working, including both VLLM and TGI services.
Docker container printouts and yaml configs are up-to-date.

Signed-off-by: Chun Tao <chun.tao@intel.com>
Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix guardrail misspelling and some heading issues.

examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
Signed-off-by: Chun Tao <chun.tao@intel.com>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the indent lost the code-block formatting. Put the four-space indent back.

examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more heading fix

examples/ChatQnA/deploy/gaudi.md Outdated Show resolved Hide resolved
Signed-off-by: Chun Tao <chun.tao@intel.com>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dbkinder dbkinder merged commit 99592d1 into opea-project:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants