Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabs for pull / build on xeon #182

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

srinarayan-srikanthan
Copy link
Contributor

No description provided.

Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull/build tab-set syntax isn't quite right.

examples/ChatQnA/deploy/xeon.md Outdated Show resolved Hide resolved
examples/ChatQnA/deploy/xeon.md Show resolved Hide resolved
examples/ChatQnA/deploy/xeon.md Outdated Show resolved Hide resolved
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
@srinarayan-srikanthan
Copy link
Contributor Author

@dbkinder let me know if the syntax looks good now. @preethivenkatesh the pr for docker install got merged in GenAIExamples. So linked it in getting started. Please review and comment.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it LGTM. Those nested tabs might be a bit confusing, but let's see!

@dbkinder dbkinder merged commit a8a2b03 into opea-project:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants