-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC - AI Avatar Animation Design #59
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great works. put some comments in PR.
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
Signed-off-by: Chun Tao <chun.tao@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks
Signed-off-by: Chun Tao <chun.tao@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a title suggested fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you didn't do a "git commit -s" so your PR is missing the required Signed-off-by: line in the commit message :(
Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
* use improved globbing pattern to collect markdown docs in the repos * add GenAIInfra/proxy docs to deploy section (was in opea-project#96) Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com>
Thank you. That was true. I was using the web interface to commit. Should never use it. I fixed it by rebasing to HEAD~2 and commited with sign-off, then force pushing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* rfc draft Signed-off-by: Chun Tao <chun.tao@intel.com> * rfc pics Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * revert unncecessary changes Signed-off-by: Chun Tao <chun.tao@intel.com> * revert unnecessary changes Signed-off-by: Chun Tao <chun.tao@intel.com> * Update 24-08-02-OPEA-AIAvatarChatbot.md Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * updates to include mjpegs Signed-off-by: Chun Tao <chun.tao@intel.com> * switch to mpg files Signed-off-by: Chun Tao <chun.tao@intel.com> * switched to gif Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowcharts Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowcharts Signed-off-by: Chun Tao <chun.tao@intel.com> * updated mermaid graph with larger font Signed-off-by: Chun Tao <chun.tao@intel.com> * updated flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * update rfc Signed-off-by: Chun Tao <chun.tao@intel.com> * delete avatar 5 Signed-off-by: Chun Tao <chun.tao@intel.com> * Update avatar flowchart Signed-off-by: Chun Tao <chun.tao@intel.com> * update Signed-off-by: Chun Tao <chun.tao@intel.com> * Update community/rfcs/24-08-02-OPEA-AIAvatarChatbot.md Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> * doc: improved use of globbing in toctree (#99) * use improved globbing pattern to collect markdown docs in the repos * add GenAIInfra/proxy docs to deploy section (was in #96) Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> --------- Signed-off-by: Chun Tao <chun.tao@intel.com> Signed-off-by: srinarayan-srikanthan <srinarayan.srikanthan@intel.com> Signed-off-by: David B. Kinder <david.b.kinder@intel.com> Co-authored-by: David Kinder <david.b.kinder@intel.com> Signed-off-by: Tom Lenth <tom.f.lenth@intel.com>
<!-- [AI Avatar Chatbot Demo on Intel® Gaudi® 2, image input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/EZa7vjON10ZCpMvE7U-SPMwBRXbVHqe1Ybsa-fmnXayNUA?e=f6FPsl) | ||
[AI Avatar Chatbot Demo on Intel® Gaudi® 2, video input](https://intel.sharepoint.com/:v:/s/mlconsultingandsupport/ESMIcBseFTdIuqkoB7TZy6ABfwR9CkfV49TvTa1X_Jihkg?e=zMH7O7) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctao456 We shouldn't have such an URL in our documentation (it's not accessible to the community). If that video is important, it should be put in a public location.
Add RFC for AI avatar animation project
opea-project/GenAIComps#400
opea-project/GenAIExamples#523