Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc submission for OPEA GenAIStudio #72

Merged
merged 3 commits into from
Sep 6, 2024
Merged

rfc submission for OPEA GenAIStudio #72

merged 3 commits into from
Sep 6, 2024

Conversation

chinyixiang
Copy link
Contributor

No description provided.

@chinyixiang
rfc submission for OPEA GenAIStudio
b2288fc 
Signed-off-by: Chin, Yi Xiang <yi.xiang.chin@intel.com>
@dbkinder
Copy link
Contributor

This seems to be a duplicate of #71 (it's updating the same file). Please close one of them :)

@chinyixiang
Added title for OPEA GenAIStudio rfc.
17625a6 
Signed-off-by: Chin, Yi Xiang <yi.xiang.chin@intel.com>
@chinyixiang chinyixiang requested a review from dbkinder August 23, 2024 02:55
@chinyixiang
Copy link
Contributor Author

This seems to be a duplicate of #71 (it's updating the same file). Please close one of them :)

Will close #71 and keep this

dbkinder
dbkinder suggested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the heading... a vew more comments about indenting content within a list item...

community/rfcs/24-08-07-OPEA-GenAIStudio.md Outdated Show resolved Hide resolved
community/rfcs/24-08-07-OPEA-GenAIStudio.md Outdated Show resolved Hide resolved
@chinyixiang
Fixed formatting for 24-08-07-OPEA-GenAIStudio.md
37fc795 
Signed-off-by: Chin, Yi Xiang <yi.xiang.chin@intel.com>
@chinyixiang chinyixiang requested a review from dbkinder August 27, 2024 02:56
dbkinder
dbkinder approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@kevinintel kevinintel merged commit 4401d19 into opea-project:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkinder dbkinder dbkinder approved these changes

@ftian1 ftian1 ftian1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chinyixiang @dbkinder @ftian1 @kevinintel