Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace OPEA_API word doc with rst version #94

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

dbkinder
Copy link
Contributor

@dbkinder dbkinder commented Sep 8, 2024

  • The word (.docx) version of the OPEA API specification was stored in the docs repo and wasn't convenient for developers to read or maintain. Convert the word doc to reST. Note though this is a conversion that maintains some technical errors found during the transcription. The intention is to make this API spec more visible and able to be reviewed and updated easily in this reST form.

  • Create a more easily found document structure for this and other developer guides (previously in the community area) and move a few around to fit into this new navigation structure.

* The word (.docx) version of the OPEA API specification was stored in
  the docs repo and wasn't convenient for developers to read or
  maintain.  Convert the word doc to reST. Note though this is a
  conversion that maintains some technical errors found during the
  transcription.  The intention is to make this API spec more visible
  and able to be reviewed and updated easily in this reST form.

* Create a more easily found document structure for this and other
  developer guides (previously in the community area) and move a few
  around to fit into this new navigation structure.

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
Copy link
Collaborator

@ftian1 ftian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with such change. In the future, we may need something like this https://huggingface.github.io/text-generation-inference/, which is rendered from a json file https://huggingface.github.io/text-generation-inference/openapi.json.

@dbkinder
Copy link
Contributor Author

I am ok with such change. In the future, we may need something like this https://huggingface.github.io/text-generation-inference/, which is rendered from a json file https://huggingface.github.io/text-generation-inference/openapi.json.

Do we have such a JSON file for OPEA's API?

Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ftian1
Copy link
Collaborator

ftian1 commented Sep 11, 2024

I am ok with such change. In the future, we may need something like this https://huggingface.github.io/text-generation-inference/, which is rendered from a json file https://huggingface.github.io/text-generation-inference/openapi.json.

Do we have such a JSON file for OPEA's API?

no yet

@kevinintel kevinintel merged commit 7ab8011 into opea-project:main Sep 11, 2024
1 check passed
tomlenth pushed a commit that referenced this pull request Sep 17, 2024
* The word (.docx) version of the OPEA API specification was stored in
  the docs repo and wasn't convenient for developers to read or
  maintain.  Convert the word doc to reST. Note though this is a
  conversion that maintains some technical errors found during the
  transcription.  The intention is to make this API spec more visible
  and able to be reviewed and updated easily in this reST form.

* Create a more easily found document structure for this and other
  developer guides (previously in the community area) and move a few
  around to fit into this new navigation structure.

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
Signed-off-by: Tom Lenth <tom.f.lenth@intel.com>
@dbkinder dbkinder deleted the API branch September 25, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants