Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update docbuild instructions #98

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

dbkinder
Copy link
Contributor

@dbkinder dbkinder commented Sep 9, 2024

Put back using both origin and upstream in the doc build instructions so devleopers won't get confused if they've already got repos checked out for their development work.

Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested

developer-guides/docbuild.rst Outdated Show resolved Hide resolved
developer-guides/docbuild.rst Outdated Show resolved Hide resolved
developer-guides/docbuild.rst Outdated Show resolved Hide resolved
developer-guides/docbuild.rst Outdated Show resolved Hide resolved
Put back using both origin and upstream in the doc build instructions so
devleopers won't get confused if they've already got repos checked out
for their development work.

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
@kevinintel kevinintel merged commit 23605b5 into opea-project:main Sep 11, 2024
1 check passed
tomlenth pushed a commit that referenced this pull request Sep 17, 2024
Put back using both origin and upstream in the doc build instructions so
devleopers won't get confused if they've already got repos checked out
for their development work.

Signed-off-by: David B. Kinder <david.b.kinder@intel.com>
Signed-off-by: Tom Lenth <tom.f.lenth@intel.com>
@dbkinder dbkinder deleted the docgen9 branch September 25, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants