feat: user logging #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
|
❌ Code formatting check failed. Please run |
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
arlowhite
approved these changes
Dec 4, 2024
| import { initialiseAdmins } from './initialise'; | ||
|
|
||
| console.log('Initializing admins...'); | ||
| initialiseAdmins(); |
There was a problem hiding this comment.
are you sure you want this here? previously, it was called by /init or src\infra\lambda.ts
With it running automatically like this you could have multiple instances running the function simultaneously. Typically I would add a lock to prevent this, but in this case the risk is minimal and we're not running multiple instances anyway. Redundant updates are fine and duplicate user inserts won't happen due to email unique constraint.
There was a problem hiding this comment.
Just a thought, but could consider doing this management with database migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic user logging for logins, change passwords and change roles.
This route includes pagination.
Also bumps prisma to new major version v6 - no breaking changes for us.