Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserves body_params *and params resolved by Plug.Parsers #398

Closed
wants to merge 3 commits into from

Conversation

riccardomanfrin
Copy link
Contributor

I'm proposing the use of an additional config key (defaulted to false)

config :open_api_spex, conn_private_body_decode: true

to move the casted body result into the :private fields of the Plug.Conn.

While preserving the backward compat, it feels more inline with Plug.Conn doc and preserves the parsers result for inspection

Thanks

@mbuhot
Copy link
Collaborator

mbuhot commented Nov 25, 2021

See also #376

@riccardomanfrin
Copy link
Contributor Author

riccardomanfrin commented Nov 26, 2021

See also #376

didn't want to be invasive, but yes in this sense I forgot the params looking at his changes. If direction is ok and acceptable I can include those in a second round patch

@riccardomanfrin riccardomanfrin changed the title Preserves body_params resolved by Plug.Parsers Preserves body_params *and params resolved by Plug.Parsers Nov 29, 2021
@riccardomanfrin
Copy link
Contributor Author

I've added also the params. Credits to #376

@mbuhot
Copy link
Collaborator

mbuhot commented May 15, 2022

Closing in favour of #425

@mbuhot mbuhot closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants