Split set_username into register_user and update_username #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megrogan
approved these changes
Dec 24, 2020
| } | ||
|
|
||
| #[derive(CandidType, Deserialize, Debug)] | ||
| pub struct User { |
There was a problem hiding this comment.
Did we say type defs at the top followed by impl?
There was a problem hiding this comment.
I thought it was type def followed by impl for that type, then the next type, and so on.
| @@ -1,10 +1,10 @@ | |||
| use ic_cdk::storage; | |||
| use crate::domain::user_data::UserData; | |||
| use crate::domain::user_store::UserStore; | |||
|
|
|||
| pub fn query() -> Option<String> { | |||
There was a problem hiding this comment.
Do we still need this function?
There was a problem hiding this comment.
We need a way of getting the details of the current user.
Currently this is the only way.
But we should change this to a 'get_current_user' method which returns more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.