Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable admission and feature gate #102

Conversation

qiujian16
Copy link
Member

Signed-off-by: Jian Qiu jqiu@redhat.com

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and mikeshng November 16, 2022 08:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@ycyaoxdu ycyaoxdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit aa04777 into open-cluster-management-io:standalone-controlplane Nov 16, 2022
@qiujian16 qiujian16 deleted the enable-admission branch November 16, 2022 08:37
zhujian7 added a commit to zhujian7/ocm that referenced this pull request Aug 19, 2024
Signed-off-by: zhujian <jiazhu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants