Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add addon filter for addonmanger #177

Conversation

zhiweiyin318
Copy link
Member

No description provided.

@zhiweiyin318 zhiweiyin318 force-pushed the fix-addonmanager branch 6 times, most recently from 9994d72 to 0373f60 Compare April 25, 2023 12:44
@zhiweiyin318
Copy link
Member Author

/assign @qiujian16
/assign @haoqing0110

return nil
}

klog.Infof("\n ### cma filtered: %v+", clusterManagementAddon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is unnecessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@zhiweiyin318 zhiweiyin318 force-pushed the fix-addonmanager branch 2 times, most recently from d6c68ca to cadbd27 Compare April 25, 2023 13:13
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2786bef into open-cluster-management-io:main Apr 26, 2023
@zhiweiyin318 zhiweiyin318 deleted the fix-addonmanager branch April 26, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants