Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support config image override by addon deployment config #183

Conversation

zhujian7
Copy link
Member

No description provided.

Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 force-pushed the config-registries branch 2 times, most recently from 41638f3 to e743f9c Compare May 24, 2023 06:27
Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

/cc @zhiweiyin318 @qiujian16

@openshift-ci openshift-ci bot requested a review from zhiweiyin318 May 24, 2023 09:23
@zhujian7 zhujian7 changed the title WIP: support config image override by addon deployment config support config image override by addon deployment config May 26, 2023
@zhiweiyin318
Copy link
Member

look good to me.

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ebc4aa8 into open-cluster-management-io:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants