✨ support addon health probe for checking deployment availability #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
health-probe-deployment
branch
3 times, most recently
from
5133932
to
dc52a56
Compare
zhujian7
changed the title
|
/assign @qiujian16 @zhiweiyin318 |
zhujian7
force-pushed
the
health-probe-deployment
branch
2 times, most recently
from
eea967c
to
7dd4b5d
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
health-probe-deployment
branch
from
7dd4b5d
to
9f34253
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Do we have plan to support more general healthcheck, like StatefulSets, DaemonSet? |
|
/lgtm |
openshift-merge-robot
merged commit 6a328fa
into
open-cluster-management-io:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new type to check addon health
DeploymentAvailability, the addon status will be ok when all deployments deployed on the agent cluster are available.