-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support override addon images by the cluster's annotation #197
✨ Support override addon images by the cluster's annotation #197
Conversation
/hold |
fd66140
to
9ace1a6
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
4bd992c
to
545ce69
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
/unhold |
/lgtm |
Signed-off-by: zhujian <jiazhu@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5c2bd0b
into
open-cluster-management-io:main
Make the addon framework support override addon agents' images by the cluster's annotation.
If the managedCluster has annotation
open-cluster-management.io/image-registries
in format:For example:
If the addon manager uses the GetAgentImageValues func in the addon manager like:
and use the "global.imageOverrides.helloWorldHelm" placeholder in the agent manifests yaml like:
The image will be overridden to "quay.io/ocm/addon-examples"
Note: if the addon is also configured by the addonDeploymentConfig to override the image, the addonDeploymentConfig will take precedence over this annotation.