Add a new AgentInstallNamespace option for addon registration #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiujian16
reviewed
Aug 28, 2023
pkg/agent/inteface.go
Outdated
| // It will override the installNamespace on ManagedClusterAddon spec if set and the returned value is not empty. | ||
| // Note: Set this very carefully. If this is set, the addon agent must be deployed in the same namespace, which | ||
| // means when implementing Manifests function in AgentAddon interface, the namespace of the addon agent manifest | ||
| // must be set to the smae value returned by this function. |
There was a problem hiding this comment.
Suggested change
| // must be set to the smae value returned by this function. | |
| // must be set to the same value returned by this function. |
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
registration-install-namespace
branch
from
340bca6
to
e412888
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit d5b1f95
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.