add a helper func for setting agent install namespace from addon deployment config #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhujian7
force-pushed
the
install-namespace
branch
3 times, most recently
from
f8c4679 to
fbdf32e
Compare
|
/cc @qiujian16 |
zhujian7
force-pushed
the
install-namespace
branch
2 times, most recently
from
fbdf32e to
c2e3422
Compare
qiujian16
reviewed
Sep 6, 2023
pkg/utils/namespace.go
Outdated
| } | ||
| } | ||
|
|
||
| // GetDesiredAddOnDeployment returns the desired template of the addon |
There was a problem hiding this comment.
Suggested change
| // GetDesiredAddOnDeployment returns the desired template of the addon | |
| // GetDesiredAddOnDeployment returns the desired addonDeploymentConfig of the addon |
pkg/utils/namespace.go
Outdated
| ) | ||
|
|
||
| func AgentInstallNamespaceFromDeploymentConfig( | ||
| adcgetter func(ctx context.Context, namespace, name string) (*addonapiv1alpha1.AddOnDeploymentConfig, error), |
There was a problem hiding this comment.
think this one is supposed to be used in a controller to update status on addon?
How about we have a func to sync namespace in config to addon.status?
cmd/example/helloworld/main.go
Outdated
| @@ -93,6 +93,11 @@ func runController(ctx context.Context, kubeConfig *rest.Config) error { | |||
| utilrand.String(5), | |||
| ) | |||
|
|
|||
| // Set agent install namespace from addon deployment config if it exists | |||
| registrationOption.AgentInstallNamespace = utils.AgentInstallNamespaceFromDeploymentConfig( | |||
There was a problem hiding this comment.
I do not think we should only set during start
zhujian7
force-pushed
the
install-namespace
branch
2 times, most recently
from
6ba3ee2 to
171db9a
Compare
…oyment config Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
install-namespace
branch
from
171db9a to
f818755
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 5497e73
into
open-cluster-management-io:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper func for setting the
registrationOption.AgentInstallNamespace, This helper func will try to get the namespace from the addon deployment config. If the addon does not support addon deployment config or there is no matched addon deployment config, it will return an empty string.