-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue updating deployment manifests when uninstalling #226
Continue updating deployment manifests when uninstalling #226
Conversation
/cc @JustinKuli |
/hold if you agree with the approach, I'll work to get the tests working |
/LGTM |
e30130d
to
f9797c1
Compare
/unhold this is ready for review with the tests fixed |
/cc @zhujian7 |
This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode. Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem. Relates: https://issues.redhat.com/browse/ACM-8947 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
f9797c1
to
338a904
Compare
/lgtm |
@zhiweiyin318 could you please take another look? |
/LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
34f78ec
into
open-cluster-management-io:main
This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode.
Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem.
Relates:
https://issues.redhat.com/browse/ACM-8947