Continue updating deployment manifests when uninstalling #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @JustinKuli |
|
/hold if you agree with the approach, I'll work to get the tests working |
|
/LGTM |
mprahl
force-pushed
the
continue-during-uninstall
branch
from
e30130d
to
f9797c1
Compare
|
/unhold this is ready for review with the tests fixed |
|
/cc @zhujian7 |
zhujian7
reviewed
Dec 11, 2023
This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode. Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem. Relates: https://issues.redhat.com/browse/ACM-8947 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
continue-during-uninstall
branch
from
f9797c1
to
338a904
Compare
|
/lgtm |
|
@zhiweiyin318 could you please take another look? |
|
/LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 34f78ec
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an addon to update its deployment manifests while the predelete hook is running. This is useful when telling the addon to enter uninstall mode.
Additionally, if there is a bug in the uninstall and it keeps the uninstall from succeeding, we need to allow container image updates to move forward in the event the update fixes the problem.
Relates:
https://issues.redhat.com/browse/ACM-8947