fix e2e agent ns is failed to created when it is deleting #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweiyin318
force-pushed
the
fix-e2e
branch
2 times, most recently
from
25aa481
to
ba2830d
Compare
zhujian7
reviewed
Dec 14, 2023
test/e2e/helloworld_helm_test.go
Outdated
| return err | ||
| }, eventuallyTimeout, eventuallyInterval).ShouldNot(gomega.HaveOccurred()) | ||
| return false | ||
| }, eventuallyTimeout, eventuallyInterval).Should(gomega.BeTrue()) |
There was a problem hiding this comment.
return error is helpful for debugging when it fails since it will print the error message, but return bool will not.
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318
force-pushed
the
fix-e2e
branch
from
ba2830d
to
8b8fa99
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 634b072
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.