Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix deploying ocm error in e2e #245

Merged

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Mar 7, 2024

The PR in ocm repo changed the default install mode to Singleton, so there will be only one klusterlet-agent on the manged cluster

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7
Copy link
Member Author

zhujian7 commented Mar 7, 2024

/cc @zhiweiyin318 @haoqing0110

Copy link
Member

@haoqing0110 haoqing0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eb30ff5 into open-cluster-management-io:main Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants