-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 remove duplicate controller and installstrategy #252
🌱 remove duplicate controller and installstrategy #252
Conversation
0cd8cd4
to
4ea888a
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
Signed-off-by: haoqing0110 <qhao@redhat.com>
4ea888a
to
6b13251
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
6b13251
to
4eca494
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
/assign @qiujian16 |
) | ||
|
||
// clusterManagementAddonController reconciles cma on the hub. | ||
type clusterManagementAddonController struct { | ||
// cmaManagedByController reconciles clustermanagementaddon on the hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to remove this? will remove this controller later when addon manager no longer honor this annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the controller is to remove the "self" added by framework 0.8.1/0.9.0.
will remove this controller later when addon manager no longer honor this annotation?
Yes. May need to keep this as long as we support 0.8.1/0.9.0, or users have to remove the "self" manually when they do a framework upgrade.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @zhujian7 |
/lgtm |
b0ef02a
into
open-cluster-management-io:main
Summary
Ref open-cluster-management-io/ocm#355
Related issue(s)
Fixes #