🌱 Use install strategy in addon example and e2e #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
install-update
branch
2 times, most recently
from
64a5bb9
to
58a8369
Compare
|
/lgtm |
haoqing0110
reviewed
Mar 21, 2024
examples/deploy/addon/helloworld/resources/helloworld_clustermanagementaddon.yaml
Show resolved
Hide resolved
qiujian16
force-pushed
the
install-update
branch
from
58a8369
to
d63b19c
Compare
haoqing0110
reviewed
Mar 21, 2024
test/e2e/helloworld_test.go
Outdated
| @@ -441,6 +441,7 @@ func prepareAddOnDeploymentConfig(namespace string) error { | |||
| NodeSelector: nodeSelector, | |||
| Tolerations: tolerations, | |||
| }, | |||
| AgentInstallNamespace: metav1.NamespaceDefault, | |||
There was a problem hiding this comment.
test/e2e/helloworld_helm_test.go also calls prepareAddOnDeploymentConfig and prepareImageOverrideAddOnDeploymentConfig, need to update the corresponding namespace when checking the generated resource.
haoqing0110
reviewed
Mar 21, 2024
examples/deploy/addon/helloworld/resources/helloworld_clustermanagementaddon.yaml
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
install-update
branch
5 times, most recently
from
4444cd3
to
77eab54
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
install-update
branch
from
77eab54
to
ef0fbc8
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 52eef42
into
open-cluster-management-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #