-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use install strategy in addon example and e2e #253
🌱 Use install strategy in addon example and e2e #253
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
64a5bb9
to
58a8369
Compare
/lgtm |
examples/deploy/addon/helloworld/resources/helloworld_clustermanagementaddon.yaml
Show resolved
Hide resolved
58a8369
to
d63b19c
Compare
test/e2e/helloworld_test.go
Outdated
@@ -441,6 +441,7 @@ func prepareAddOnDeploymentConfig(namespace string) error { | |||
NodeSelector: nodeSelector, | |||
Tolerations: tolerations, | |||
}, | |||
AgentInstallNamespace: metav1.NamespaceDefault, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/e2e/helloworld_helm_test.go also calls prepareAddOnDeploymentConfig
and prepareImageOverrideAddOnDeploymentConfig
, need to update the corresponding namespace when checking the generated resource.
examples/deploy/addon/helloworld/resources/helloworld_clustermanagementaddon.yaml
Outdated
Show resolved
Hide resolved
4444cd3
to
77eab54
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
77eab54
to
ef0fbc8
Compare
/lgtm |
52eef42
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #