Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Start ocm env using clusteradm #254

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and elgnay March 20, 2024 08:35
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16 qiujian16 force-pushed the clusteradm branch 12 times, most recently from 4d54e08 to 3c7a7ea Compare March 21, 2024 03:15
@qiujian16
Copy link
Member Author

/assign @zhujian7

@zhiweiyin318
Copy link
Member

/lgtm

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@zhiweiyin318
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2024
@zhujian7
Copy link
Member

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit e8778a9 into open-cluster-management-io:main Mar 21, 2024
12 checks passed
@zhujian7
Copy link
Member

@dhaiducek @mprahl FYI: I know there seems to be a policy repo that uses the cloning ocm repo and executing make commands to install an ocm env, which is error-prone, here is an example of using the clusteradm to set up an ocm env for your reference, hope this is helpful.

@dhaiducek
Copy link
Member

dhaiducek commented Mar 21, 2024

@zhujian7 Thanks for tagging us! clusteradm could be a good solution and we'd definitely be on board for a more reliable build, but for our use-cases:

  • We want to be able to deploy stolostron-specific code/images from a particular version (which I'm not sure would be quite as simple with clusteradm?)
  • We want test against the latest images rather than a specific version

Would both of these be straightforward with clusteradm also?

@qiujian16 qiujian16 deleted the clusteradm branch March 22, 2024 00:21
@zhujian7
Copy link
Member

@dhaiducek I am not quite sure if this is what you need, but you can have a try.
there are --bundle-version='xx' and --image-registry='xxx' options for the clusteradm init and clusteradm join commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants