-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ check return err for customized agent install namespace #257
⚠️ check return err for customized agent install namespace #257
Conversation
/hold |
examples/deploy/addon/helloworld-helm/resources/helloworld_helm_clustermanagementaddon.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: zhujian <jiazhu@redhat.com>
Signed-off-by: zhujian <jiazhu@redhat.com>
/assign @qiujian16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be542a6
into
open-cluster-management-io:main
/cherrypick release-0.9 |
@qiujian16: #257 failed to apply on top of branch "release-0.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ter-management-io#257) * check return err for customized agent install namespace Signed-off-by: zhujian <jiazhu@redhat.com> * Fix e2e Signed-off-by: zhujian <jiazhu@redhat.com> * Use default namespace if addon deployment config is not configured Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…ter-management-io#257) * check return err for customized agent install namespace Signed-off-by: zhujian <jiazhu@redhat.com> * Fix e2e Signed-off-by: zhujian <jiazhu@redhat.com> * Use default namespace if addon deployment config is not configured Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…ter-management-io#257) * check return err for customized agent install namespace Signed-off-by: zhujian <jiazhu@redhat.com> * Fix e2e Signed-off-by: zhujian <jiazhu@redhat.com> * Use default namespace if addon deployment config is not configured Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com>
* check return err for customized agent install namespace * Fix e2e * Use default namespace if addon deployment config is not configured --------- Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Jian Zhu <jiazhu@redhat.com>
Summary
This PR changes the
RegistrationOption
interface:from
to
we need this error info to determine whether the namespace is empty or an error occurred.
Related issue(s)
Fixes #