Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update readme with addon contributions link #266

Merged

Conversation

mikeshng
Copy link
Member

Summary

Update the README with addon contribution repo link

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 May 14, 2024 13:51
@mikeshng
Copy link
Member Author

Doc update like this one should not trigger e2e.
Did I not do something in the PR?

@mikeshng mikeshng force-pushed the update-readme branch 2 times, most recently from 18bf084 to 85e26ae Compare May 14, 2024 15:44
@xuezhaojun
Copy link
Member

Doc update like this one should not trigger e2e. Did I not do something in the PR?

No, I met the same e2e which should not occur, it seems like some thiing addon-framework e2e depends on changed, for example the images it use or the clusteradmin.

Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng
Copy link
Member Author

Doc update like this one should not trigger e2e. Did I not do something in the PR?

No, I met the same e2e which should not occur, it seems like some thiing addon-framework e2e depends on changed, for example the images it use or the clusteradmin.

Thanks and go to sleep 😅

@xuezhaojun
Copy link
Member

/lgtm

@zhujian7
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2376b63 into open-cluster-management-io:main May 16, 2024
13 checks passed
@mikeshng mikeshng deleted the update-readme branch May 16, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants