Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 read config referent from the desired config #269

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

We should get from desiredConfig, it is not directly from
configReference which is going to be deprecated.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and zhujian7 May 16, 2024 09:38
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16 qiujian16 force-pushed the desired-config branch 4 times, most recently from 4c16bf7 to 77aee65 Compare May 17, 2024 00:50
pkg/utils/addon_config.go Outdated Show resolved Hide resolved
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16
Copy link
Member Author

/cherry-pick release-0.9

@openshift-cherrypick-robot
Copy link
Contributor

@qiujian16: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e24923d into open-cluster-management-io:main May 21, 2024
13 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@qiujian16: new pull request created: #271

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants