Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate API to *_types.go files #112

Open
qiujian16 opened this issue Dec 9, 2021 · 1 comment
Open

Separate API to *_types.go files #112

qiujian16 opened this issue Dec 9, 2021 · 1 comment
Assignees
@ilan-pinto
Labels
help wanted Extra attention is needed

Comments

@qiujian16
Copy link
Member

multiple apis are put in one single types.go file which make it hard to read. It is better that we can separate them to multiple files.
@qiujian16 qiujian16 added the help wanted Extra attention is needed label Dec 9, 2021
@ilan-pinto
Copy link
Member

/assign @ilan-pinto

ilan-pinto added a commit to ilan-pinto/api that referenced this issue Dec 20, 2021
@ilan-pinto
fixed issue open-cluster-management-io#112 - spreated types.go file
e03f52c
ilan-pinto added a commit to ilan-pinto/api that referenced this issue Dec 20, 2021
@ilan-pinto
fixed issue open-cluster-management-io#112 - spreated types.go file
5523315 
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
ilan-pinto added a commit to ilan-pinto/api that referenced this issue Dec 20, 2021
@ilan-pinto
fixed issue open-cluster-management-io#112 - spreated types.go file
cb026fc 
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>

fixed format

Signed-off-by: Ilan Pinto <ilpinto@redhat.com>

fixed issue open-cluster-management-io#112 - spreated types.go file

renamed types
ilan-pinto added a commit to ilan-pinto/api that referenced this issue Dec 21, 2021
@ilan-pinto
Fixed issue open-cluster-management-io#112 spreated types.go
866e4ed 
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
openshift-merge-robot pushed a commit that referenced this issue Dec 21, 2021
@ilan-pinto
Fixed issue #112 separated types.go (#123)
55953c7 
* Fixed issue #112 spreated types.go

Signed-off-by: Ilan Pinto <ilpinto@redhat.com>

* fixed format

Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilan-pinto ilan-pinto

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qiujian16 @ilan-pinto