-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version in operator status #139
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jian Qiu <jqiu@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @yue9944882 |
@qiujian16 is this for the print column? i guess the new |
also for the upgrade case, that we can know the previous version. |
@@ -127,6 +127,9 @@ type ClusterManagerStatus struct { | |||
// +optional | |||
ObservedGeneration int64 `json:"observedGeneration,omitempty"` | |||
|
|||
// Version represents the version of the compoenents in cluster manager | |||
Version ClusterManagerVersion `json:"version,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either make this a pointer or remove omitempty
?
// KlusterletStatus represents the current status of Klusterlet agent. | ||
type KlusterletStatus struct { | ||
// ObservedGeneration is the last generation change you've dealt with | ||
// +optional | ||
ObservedGeneration int64 `json:"observedGeneration,omitempty"` | ||
|
||
// Version represents the version of the compoenents in klusterlet | ||
Version KlusterletVersion `json:"version,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@qiujian16 will this work for vendor customized version? e.g. conventionally we extend a platform version suffix after the semver |
I think we would read version in version.go. So yes if the customized version is added in ldflag. |
@qiujian16: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jian Qiu jqiu@redhat.com