Add version in operator status #139
Conversation
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @yue9944882 |
|
@qiujian16 is this for the print column? i guess the new |
|
also for the upgrade case, that we can know the previous version. |
| @@ -127,6 +127,9 @@ type ClusterManagerStatus struct { | |||
| // +optional | |||
| ObservedGeneration int64 `json:"observedGeneration,omitempty"` | |||
|
|
|||
| // Version represents the version of the compoenents in cluster manager | |||
| Version ClusterManagerVersion `json:"version,omitempty"` | |||
There was a problem hiding this comment.
either make this a pointer or remove omitempty?
| // KlusterletStatus represents the current status of Klusterlet agent. | ||
| type KlusterletStatus struct { | ||
| // ObservedGeneration is the last generation change you've dealt with | ||
| // +optional | ||
| ObservedGeneration int64 `json:"observedGeneration,omitempty"` | ||
|
|
||
| // Version represents the version of the compoenents in klusterlet | ||
| Version KlusterletVersion `json:"version,omitempty"` |
@qiujian16 will this work for vendor customized version? e.g. conventionally we extend a platform version suffix after the semver |
|
I think we would read version in version.go. So yes if the customized version is added in ldflag. |
|
@qiujian16: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jian Qiu jqiu@redhat.com