-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon certificate tracking and more addon status condition types #140
base: main
Are you sure you want to change the base?
Addon certificate tracking and more addon status condition types #140
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
86c6b43
to
b797065
Compare
@@ -58,6 +58,18 @@ type RegistrationConfig struct { | |||
// | |||
// +optional | |||
Subject Subject `json:"subject,omitempty"` | |||
|
|||
// certificateStatus actively tracks the status of the certificate used by the addon. | |||
CertificateStatus *RegistrationConfigCertificateStatus `json:"certificateStatus,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field is only used for configuration of registration. I do not think we want to expose this field to addon when setting the configuration. Maybe we should move this out with the name of RegistrationStatuses
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're moving this out, we will need an identifier field for each certificate status struct to correlate the status and registration config. i cant find such an identifier to use, otherwise we will need to duplicate the whole config. wdyt?
2ccc1cc
to
6c045d4
Compare
Signed-off-by: yue9944882 <291271447@qq.com>
6c045d4
to
6fd8353
Compare
/hold backoff api-changes until the next release |
@yue9944882: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
RegistrationApplied
andManifestApplied