Add addon template api #239
Conversation
zhujian7
force-pushed
the
addon-template-new
branch
from
33a4002
to
0f70d80
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
addon-template-new
branch
from
0f70d80
to
bbf8f42
Compare
| // | ||
| // AddOnTemplate is a cluster-scoped resource, and will only be used | ||
| // on the hub cluster. | ||
| type AddOnTemplate struct { |
There was a problem hiding this comment.
should it start with "addon" to be consistent with addonDeploymentConfig?
| // provided ClusterRole/Role to the "system:open-cluster-management:cluster:<cluster-name>:addon:<addon-name>" | ||
| // Group. | ||
| type HubPermissionConfig struct { | ||
| // Type of the permissions setting. It defines how to bind the roleRef |
There was a problem hiding this comment.
we need to describe the meaning of CurrentCluster and singlenamespace
There was a problem hiding this comment.
described here, should I move them into the HubPermissionConfig struct？
There was a problem hiding this comment.
I think we should for generating the openapi doc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
addon-template-new
branch
from
bbf8f42
to
cf0435f
Compare
|
/lgtm |
No description provided.