Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singleton mode for klusterlet #246

Conversation

qiujian16
Copy link
Member

with inprocess mode, agent will be run in the
same process with the klusterlet.

@openshift-ci openshift-ci bot requested review from deads2k and mdelder June 30, 2023 02:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

with inprocess mode, agent will be run in the
same process with the klusterlet.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@qiujian16 qiujian16 changed the title Add inprocess mode for klusterlet Add singleton mode for klusterlet Jun 30, 2023
@zhujian7
Copy link
Member

zhujian7 commented Jul 3, 2023

LGTM

@xuezhaojun
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit d9a47a8 into open-cluster-management-io:main Jul 3, 2023
6 checks passed
@qiujian16 qiujian16 deleted the inprocess-mode branch July 3, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants