Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable addon management feature gate by default #249

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jul 4, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from mdelder and qiujian16 July 4, 2023 15:15
@qiujian16
Copy link
Member

let's ask for comment on the ocm slack before we switch.

@zhujian7
Copy link
Member Author

zhujian7 commented Jul 5, 2023

/hold

Signed-off-by: zhujian <jiazhu@redhat.com>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7 zhujian7 changed the title enable addon manager by default enable addon management feature gate by default Jul 14, 2023
@zhujian7
Copy link
Member Author

/unhold

@openshift-merge-robot openshift-merge-robot merged commit ef97df0 into open-cluster-management-io:main Jul 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants