Add cluster annotations. #252
Conversation
xuezhaojun
force-pushed
the
add-initcluster-annotations-and-labels
branch
from
1dc5360
to
40e0f49
Compare
|
/assign @qiujian16 |
xuezhaojun
force-pushed
the
add-initcluster-annotations-and-labels
branch
2 times, most recently
from
95cf570
to
cc34a46
Compare
xuezhaojun
changed the title
xuezhaojun
force-pushed
the
add-initcluster-annotations-and-labels
branch
from
cc34a46
to
b73df11
Compare
xuezhaojun
changed the title
operator/v1/types.go
Outdated
| @@ -107,6 +107,13 @@ type RegistrationConfiguration struct { | |||
| // he can set featuregate/Foo=false before upgrading. Let's say the cluster-admin wants featuregate/Foo=false. | |||
| // +optional | |||
| FeatureGates []FeatureGate `json:"featureGates,omitempty"` | |||
|
|
|||
| // ClusterAnnotations is a set of annotations that agent used when creating a managed cluster. | |||
| // After the managed cluster is created, modify this field won't affect the managed cluster any more. | |||
There was a problem hiding this comment.
also need a const definition of this annotationPrefix
There was a problem hiding this comment.
Yes, adding one now...
There was a problem hiding this comment.
Added the ClusterAnnotationsKeyPrefix , PTAL.
There was a problem hiding this comment.
After the managed cluster is created, modify this field won''t affect the managed cluster any more. But if the managed cluster is deleted from the hub, it will be used again when agent attempt to create a managed cluster. The annotations must has prefix: "agent.open-cluster-management.io", otherwise, it will be ignored.'
I do not think you still need these.
There was a problem hiding this comment.
Agree, the content deleted. PTAL.
xuezhaojun
force-pushed
the
add-initcluster-annotations-and-labels
branch
from
acdb7fb
to
5bd04fa
Compare
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
add-initcluster-annotations-and-labels
branch
from
5bd04fa
to
c875c3b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit c0c9fb5
into
open-cluster-management-io:main
…cluster-management-io#252) Signed-off-by: xuezhaojun <zxue@redhat.com>
…cluster-management-io#252) Signed-off-by: xuezhaojun <zxue@redhat.com>
No description provided.