-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image registries annotation key #256
Add image registries annotation key #256
Conversation
@@ -234,3 +234,18 @@ const ( | |||
// ClusterNameLabelKey is the key of a label to set ManagedCluster name. | |||
ClusterNameLabelKey = "open-cluster-management.io/cluster-name" | |||
) | |||
|
|||
const ( | |||
// ClusterImageRegistriesAnnotationKey is an annotation key on ManagedCluster to configure image override for addons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also mention addonDeploymentConfig will override this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
/hold |
Signed-off-by: zhujian <jiazhu@redhat.com>
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
915f582
into
open-cluster-management-io:main
No description provided.