add add-on proxy support #257
Conversation
| // ProxyConfig holds proxy settings for add-on agent on the managed cluster. | ||
| // Either nil or empty means no proxy settings is available. | ||
| // +optional | ||
| ProxyConfig *ProxyConfig `json:"proxyConfig,omitempty"` |
There was a problem hiding this comment.
why nil if it is the same as empty?
There was a problem hiding this comment.
It will be treated as no proxy configured for the add-on agent if any of the following happens
1). The user does not specify proxyConfig;
Spec: {}
2). The user specify an empty ProxyConfig;
Spec:
ProxyConfig: {}
There was a problem hiding this comment.
But even if with no pointer, and user set Spec: {}, the API returned will be just the same as:
Spec:
ProxyConfig: {}
It seems to me that setting it as pointer is not necessary.
There was a problem hiding this comment.
That makes sense. I've updated the code as suggested.
Signed-off-by: Yang Le <yangle@redhat.com>
elgnay
force-pushed
the
support-addon-proxy
branch
from
e24a7f9
to
ac4b03e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 26e75df
into
open-cluster-management-io:main
No description provided.