🌱 addon consume common rollout api #260
Conversation
|
/hold |
| @@ -187,89 +187,9 @@ type PlacementStrategy struct { | |||
| Configs []AddOnConfig `json:"configs,omitempty"` | |||
| // The rollout strategy to apply addon configurations change. | |||
| // The rollout strategy only watches the addon configurations defined in ClusterManagementAddOn. | |||
| // +kubebuilder:default={type: UpdateAll} | |||
| // +kubebuilder:default={type: All} | |||
There was a problem hiding this comment.
this default value change might be breaking for the existing API
There was a problem hiding this comment.
Yes, the existing cma will still hold value UpdateAll.
This will impact the cma that claims managed by addon-manager, and addon-manager-controller will report error err: incorrect rollout strategy type UpdateAll .
Since the addon-manager is an experimental feature in the last release, might only need to doc this breaking change?
haoqing0110
force-pushed
the
br_addon-common-rollout-api
branch
from
c49facd
to
12e1a8f
Compare
haoqing0110
changed the title
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_addon-common-rollout-api
branch
from
12e1a8f
to
e3f65e9
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-robot
merged commit 0146ddf
into
open-cluster-management-io:main
No description provided.